github-actions[bot] commented on code in PR #31434:
URL: https://github.com/apache/doris/pull/31434#discussion_r1503595612
##########
be/src/pipeline/exec/analytic_source_operator.cpp:
##########
@@ -240,13 +240,12 @@ Status AnalyticLocalState::init(RuntimeState* state,
LocalStateInfo& info) {
return Status::OK();
}
-Status AnalyticLocalState::_reset_agg_status() {
+void AnalyticLocalState::_reset_agg_status() {
Review Comment:
warning: method '_reset_agg_status' can be made const
[readability-make-member-function-const]
```suggestion
void AnalyticLocalState::_reset_agg_status() const {
```
be/src/pipeline/exec/analytic_source_operator.h:91:
```diff
- void _reset_agg_status();
+ void _reset_agg_status() const;
```
##########
be/src/runtime/result_buffer_mgr.cpp:
##########
@@ -173,7 +173,7 @@ Status ResultBufferMgr::cancel(const TUniqueId& query_id) {
return Status::OK();
}
-Status ResultBufferMgr::cancel_at_time(time_t cancel_time, const TUniqueId&
query_id) {
+void ResultBufferMgr::cancel_at_time(time_t cancel_time, const TUniqueId&
query_id) {
Review Comment:
warning: method 'cancel_at_time' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void ResultBufferMgr::cancel_at_time(time_t cancel_time, const
TUniqueId& query_id) {
```
##########
be/src/vec/exec/vanalytic_eval_node.cpp:
##########
@@ -730,11 +730,10 @@ Status VAnalyticEvalNode::_init_result_columns() {
return Status::OK();
}
-Status VAnalyticEvalNode::_reset_agg_status() {
+void VAnalyticEvalNode::_reset_agg_status() {
Review Comment:
warning: method '_reset_agg_status' can be made const
[readability-make-member-function-const]
```suggestion
void VAnalyticEvalNode::_reset_agg_status() const {
```
be/src/vec/exec/vanalytic_eval_node.h:100:
```diff
- void _reset_agg_status();
+ void _reset_agg_status() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
