morrySnow commented on code in PR #31339:
URL: https://github.com/apache/doris/pull/31339#discussion_r1502154886
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/TimeUtils.java:
##########
@@ -335,4 +339,23 @@ private static String formatDateStr(String dateStr) {
Integer.parseInt(parts[4]),
Integer.parseInt(parts[5])) : "");
}
+ public static long timer(Runnable task) {
+ return timer(() -> {
+ task.run();
+ return null;
+ }).second;
+ }
+
+ public static <R> Pair<R, Long> timer(Callable<R> task) {
Review Comment:
not use it?
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/TimeUtils.java:
##########
@@ -335,4 +339,23 @@ private static String formatDateStr(String dateStr) {
Integer.parseInt(parts[4]),
Integer.parseInt(parts[5])) : "");
}
+ public static long timer(Runnable task) {
Review Comment:
not use it?
##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java:
##########
@@ -204,6 +207,8 @@ private void updateSummaryProfile(Map<String, String>
infos) {
}
private void updateExecutionSummaryProfile() {
+ executionSummaryProfile.addInfoString(PARSE_SQL_TIME,
getPrettyParseSqlTime());
+ executionSummaryProfile.addInfoString(NEREIDS_ANALYSIS_TIME,
getPrettyNereidsAnalysisTime());
Review Comment:
why add this twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
