github-actions[bot] commented on code in PR #31390:
URL: https://github.com/apache/doris/pull/31390#discussion_r1502002159
##########
be/src/runtime/descriptors.h:
##########
@@ -238,6 +238,8 @@
const std::string region() const { return _region; }
const std::string project() const { return _project; }
const std::string table() const { return _table; }
+ const std::string odps_url() const { return _odps_url; }
+ const std::string tunnel_url() const { return _tunnel_url; }
Review Comment:
warning: return type 'const int' is 'const'-qualified at the top level,
which may reduce code readability without improving const correctness
[readability-const-return-type]
```suggestion
std::string tunnel_url() const { return _tunnel_url; }
```
##########
be/src/runtime/descriptors.h:
##########
@@ -238,6 +238,8 @@ class MaxComputeTableDescriptor : public TableDescriptor {
const std::string region() const { return _region; }
const std::string project() const { return _project; }
const std::string table() const { return _table; }
+ const std::string odps_url() const { return _odps_url; }
Review Comment:
warning: return type 'const int' is 'const'-qualified at the top level,
which may reduce code readability without improving const correctness
[readability-const-return-type]
```suggestion
std::string odps_url() const { return _odps_url; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
