cambyzju commented on code in PR #31384:
URL: https://github.com/apache/doris/pull/31384#discussion_r1501972267
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1376,7 +1376,7 @@ Status
SegmentIterator::_lookup_ordinal_from_pk_index(const RowCursor& key, bool
// when is_include is false, we shoudle append KEY_NORMAL_MARKER to the
// encode key. Otherwise, we will get an incorrect upper bound.
encode_key_with_padding<RowCursor, true>(
- &index_key, key, _segment->_tablet_schema->num_key_columns(),
is_include, true);
+ &index_key, key, _segment->_tablet_schema->num_key_columns(),
is_include, false);
Review Comment:
https://github.com/apache/doris/pull/21770 set it to true, this pr set it to
false, which one is correct? And why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
