This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 4e5147c6a483a9771aecb70b81e24bd13149c1af
Author: Gavin Chou <gavineaglec...@gmail.com>
AuthorDate: Sun Feb 25 10:04:35 2024 +0800
[fix](parquet) Fix possible memory leak if
ParquetReader::parse_thrift_footer failed (#31375)
---
be/src/vec/exec/format/parquet/vparquet_reader.cpp | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/be/src/vec/exec/format/parquet/vparquet_reader.cpp
b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
index dd8d01f4bb1..250604e218f 100644
--- a/be/src/vec/exec/format/parquet/vparquet_reader.cpp
+++ b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
@@ -246,11 +246,10 @@ Status ParquetReader::_open_file() {
}
size_t meta_size = 0;
if (_meta_cache == nullptr) {
- RETURN_IF_ERROR(
- parse_thrift_footer(_file_reader, &_file_metadata,
&meta_size, _io_ctx));
+ auto st = parse_thrift_footer(_file_reader, &_file_metadata,
&meta_size, _io_ctx);
// wrap it with unique ptr, so that it can be released finally.
_file_metadata_ptr.reset(_file_metadata);
- _file_metadata = _file_metadata_ptr.get();
+ RETURN_IF_ERROR(st);
_column_statistics.read_bytes += meta_size;
// parse magic number & parse meta data
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
