yiguolei commented on code in PR #31376:
URL: https://github.com/apache/doris/pull/31376#discussion_r1501755957


##########
be/src/runtime/task_group/task_group.h:
##########
@@ -121,6 +129,15 @@ class TaskGroup : public 
std::enable_shared_from_this<TaskGroup> {
 
     int64_t gc_memory(int64_t need_free_mem, RuntimeProfile* profile);
 
+    void upsert_task_scheduler(taskgroup::TaskGroupInfo* tg_info, ExecEnv* 
exec_env);
+
+    void get_query_scheduler(doris::pipeline::TaskScheduler** exec_sched,
+                             vectorized::SimplifiedScanScheduler** scan_sched,
+                             ThreadPool** non_pipe_thread_pool,
+                             vectorized::SimplifiedScanScheduler** 
remote_scan_sched);
+
+    void try_stop_task_scheduler();

Review Comment:
   rename to try_stop_schedulers. because task_scheduler is for Pipeline task 
scheduler. It is very ambiguous



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to