github-actions[bot] commented on code in PR #31296:
URL: https://github.com/apache/doris/pull/31296#discussion_r1500752309
##########
be/src/vec/aggregate_functions/aggregate_function_rpc.h:
##########
@@ -385,7 +384,7 @@ class AggregateRpcUdaf final
}
void insert_result_into(ConstAggregateDataPtr __restrict place, IColumn&
to) const override {
-
static_cast<void>(this->data(const_cast<AggregateDataPtr>(place)).get(to,
_return_type));
+ THROW_IF_ERROR(this->data(const_cast<AggregateDataPtr>(place)).get(to,
_return_type));
Review Comment:
warning: method 'insert_result_into' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void insert_result_into(ConstAggregateDataPtr __restrict place,
IColumn& to) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
