weizuo93 commented on a change in pull request #6671:
URL: https://github.com/apache/incubator-doris/pull/6671#discussion_r715658037
##########
File path: be/src/olap/olap_server.cpp
##########
@@ -394,7 +394,7 @@ void StorageEngine::_compaction_tasks_producer_callback() {
for (const auto& tablet : tablets_compaction) {
int64_t permits =
tablet->prepare_compaction_and_calculate_permits(compaction_type, tablet);
- if (permits > 0 && _permit_limiter.request(permits)) {
+ if (permits >= 0 && _permit_limiter.request(permits)) {
Review comment:
> What is (permit == 0) means?
All the rowsets are empty version. The contribution of the empty version to
`permit` is 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
