github-actions[bot] commented on code in PR #31250:
URL: https://github.com/apache/doris/pull/31250#discussion_r1498956039
##########
be/src/runtime/runtime_predicate.h:
##########
@@ -43,7 +44,7 @@
public:
RuntimePredicate() = default;
- Status init(const PrimitiveType type, const bool nulls_first);
+ Status init(const PrimitiveType type, const bool nulls_first, const
std::string& col_name);
Review Comment:
warning: parameter 'nulls_first' is const-qualified in the function
declaration; const-qualification of parameters only has an effect in function
definitions [readability-avoid-const-params-in-decls]
```suggestion
Status init(const PrimitiveType type, bool nulls_first, const
std::string& col_name);
```
##########
be/src/runtime/runtime_predicate.cpp:
##########
@@ -26,20 +26,19 @@
#include "olap/column_predicate.h"
#include "olap/predicate_creator.h"
-namespace doris {
+namespace doris::vectorized {
-namespace vectorized {
-
-Status RuntimePredicate::init(const PrimitiveType type, const bool
nulls_first) {
+Status RuntimePredicate::init(const PrimitiveType type, const bool nulls_first,
Review Comment:
warning: function 'init' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status RuntimePredicate::init(const PrimitiveType type, const bool
nulls_first,
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/runtime_predicate.cpp:30:** 99 lines including whitespace
and comments (threshold 80)
```cpp
Status RuntimePredicate::init(const PrimitiveType type, const bool
nulls_first,
^
```
</details>
##########
be/src/runtime/runtime_predicate.h:
##########
@@ -43,7 +44,7 @@ class RuntimePredicate {
public:
RuntimePredicate() = default;
- Status init(const PrimitiveType type, const bool nulls_first);
+ Status init(const PrimitiveType type, const bool nulls_first, const
std::string& col_name);
Review Comment:
warning: parameter 'type' is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
Status init(PrimitiveType type, const bool nulls_first, const
std::string& col_name);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
