xy720 commented on a change in pull request #6705:
URL: https://github.com/apache/incubator-doris/pull/6705#discussion_r714538955
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/sync/SyncJobManager.java
##########
@@ -281,9 +296,6 @@ public void readField(DataInput in) throws IOException {
int size = in.readInt();
for (int i = 0; i < size; i++) {
SyncJob syncJob = SyncJob.read(in);
- if (!syncJob.isCompleted()) {
- syncJob.updateState(JobState.PENDING, true);
- }
unprotectedAddSyncJob(syncJob);
Review comment:
readfield方法理论上只会由checkpoint线程来调用，写入的catalog和现在FE运行时的catalog不是一个对象，所以这里不会有线程安全的问题。我们只需要在创建syncjob的时候检查同名，就可以保证checkpoint时不会出现重复名称了，这一检查逻辑在DdlExecutor里。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
