starocean999 commented on code in PR #31115: URL: https://github.com/apache/doris/pull/31115#discussion_r1496886978
########## regression-test/data/nereids_tpcds_shape_sf1000_p0/shape/query70.out: ########## @@ -32,23 +32,22 @@ PhysicalResultSink --------------------------------------PhysicalProject ----------------------------------------filter((ranking <= 5)) ------------------------------------------PhysicalWindow ---------------------------------------------PhysicalPartitionTopN -----------------------------------------------PhysicalDistribute[DistributionSpecHash] -------------------------------------------------PhysicalPartitionTopN ---------------------------------------------------PhysicalProject -----------------------------------------------------hashAgg[GLOBAL] -------------------------------------------------------PhysicalDistribute[DistributionSpecHash] ---------------------------------------------------------hashAgg[LOCAL] -----------------------------------------------------------PhysicalProject -------------------------------------------------------------hashJoin[INNER_JOIN] hashCondition=((store.s_store_sk = store_sales.ss_store_sk)) otherCondition=() build RFs:RF1 s_store_sk->[ss_store_sk] ---------------------------------------------------------------hashJoin[INNER_JOIN] hashCondition=((date_dim.d_date_sk = store_sales.ss_sold_date_sk)) otherCondition=() build RFs:RF0 d_date_sk->[ss_sold_date_sk] -----------------------------------------------------------------PhysicalProject -------------------------------------------------------------------PhysicalOlapScan[store_sales] apply RFs: RF0 RF1 -----------------------------------------------------------------PhysicalDistribute[DistributionSpecReplicated] -------------------------------------------------------------------PhysicalProject ---------------------------------------------------------------------filter((date_dim.d_month_seq <= 1231) and (date_dim.d_month_seq >= 1220)) -----------------------------------------------------------------------PhysicalOlapScan[date_dim] +--------------------------------------------PhysicalQuickSort[LOCAL_SORT] Review Comment: origin shape use two phase PhysicalPartitionTopN with a data shuffle between them. This pr correct the slot id issue, so the new shape use one phase PhysicalPartitionTopN + PhysicalQuickSort instead, and no need to shuffle data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
