github-actions[bot] commented on code in PR #31112:
URL: https://github.com/apache/doris/pull/31112#discussion_r1496213132
##########
be/test/vec/exec/vwal_scanner_test.cpp:
##########
@@ -210,73 +225,87 @@
_tnode.file_scan_node.tuple_id = 0;
_tnode.__isset.file_scan_node = true;
+ _scan_node = std::make_shared<NewFileScanNode>(&_obj_pool, _tnode,
*_desc_tbl);
+ _scan_node->_output_tuple_desc =
_runtime_state.desc_tbl().get_tuple_descriptor(_dst_tuple_id);
+ WARN_IF_ERROR(_scan_node->init(_tnode, &_runtime_state), "fail to init
scan_node");
+ WARN_IF_ERROR(_scan_node->prepare(&_runtime_state), "fail to prepare
scan_node");
+
+ _range_desc.start_offset = 0;
+ _range_desc.size = 1000;
+ _ranges.push_back(_range_desc);
+ _scan_range.ranges = _ranges;
+ _scan_range.__isset.params = true;
+ _scan_range.params.format_type = TFileFormatType::FORMAT_WAL;
+ _kv_cache.reset(new ShardedKVCache(48));
+
+ _runtime_state._wal_id = _txn_id;
+
+ _master_info.reset(new TMasterInfo());
_env = ExecEnv::GetInstance();
- _env->_master_info = new TMasterInfo();
+ _env->_master_info = _master_info.get();
_env->_master_info->network_address.hostname = "host name";
- _env->_master_info->network_address.port = backend_id;
+ _env->_master_info->network_address.port = _backend_id;
_env->_master_info->backend_id = 1001;
- _env->_wal_manager = WalManager::create_shared(_env, wal_dir);
+ _env->_wal_manager = WalManager::create_shared(_env, _wal_dir);
std::string base_path;
auto st = _env->_wal_manager->_init_wal_dirs_info();
- st = _env->_wal_manager->create_wal_path(db_id, tb_id, txn_id, label,
base_path);
+ st = _env->_wal_manager->create_wal_path(_db_id, _tb_id, _txn_id, _label,
base_path);
std::string src = "./be/test/exec/test_data/wal_scanner/wal";
- std::string dst = wal_dir + "/" + std::to_string(db_id) + "/" +
std::to_string(tb_id) + "/" +
- std::to_string(version) + "_" +
std::to_string(backend_id) + "_" +
- std::to_string(txn_id) + "_" + label;
+ std::string dst = _wal_dir + "/" + std::to_string(_db_id) + "/" +
std::to_string(_tb_id) + "/" +
+ std::to_string(_version) + "_" +
std::to_string(_backend_id) + "_" +
+ std::to_string(_txn_id) + "_" + _label;
std::filesystem::copy(src, dst);
}
-TEST_F(VWalScannerTest, normal) {
- std::vector<size_t> index_vector;
- index_vector.emplace_back(0);
- index_vector.emplace_back(1);
- index_vector.emplace_back(2);
- // config::group_commit_replay_wal_dir = wal_dir;
- NewFileScanNode scan_node(&_obj_pool, _tnode, *_desc_tbl);
- scan_node._output_tuple_desc =
_runtime_state.desc_tbl().get_tuple_descriptor(_dst_tuple_id);
- static_cast<void>(scan_node.init(_tnode, &_runtime_state));
- auto status = scan_node.prepare(&_runtime_state);
- EXPECT_TRUE(status.ok());
-
- std::vector<TFileRangeDesc> ranges;
- TFileRangeDesc range_desc;
- {
- range_desc.start_offset = 0;
- range_desc.size = 1000;
- }
- ranges.push_back(range_desc);
- TFileScanRange scan_range;
- scan_range.ranges = ranges;
- scan_range.__isset.params = true;
- scan_range.params.format_type = TFileFormatType::FORMAT_WAL;
- std::unique_ptr<ShardedKVCache> _kv_cache;
- _kv_cache.reset(new ShardedKVCache(48));
- _runtime_state._wal_id = txn_id;
- VFileScanner scanner(&_runtime_state, &scan_node, -1, scan_range,
_profile, _kv_cache.get());
- scanner._is_load = false;
+void VWalScannerTest::generate_scanner(std::shared_ptr<VFileScanner>& scanner)
{
Review Comment:
warning: method 'generate_scanner' can be made static
[readability-convert-member-functions-to-static]
be/test/vec/exec/vwal_scanner_test.cpp:47:
```diff
- void generate_scanner(std::shared_ptr<VFileScanner>& scanner);
+ static void generate_scanner(std::shared_ptr<VFileScanner>& scanner);
```
##########
be/test/vec/exec/vwal_scanner_test.cpp:
##########
@@ -73,12 +78,18 @@
ScannerCounter _counter;
std::vector<TExpr> _pre_filter;
TPlanNode _tnode;
- TUniqueId unique_id;
- TQueryOptions query_options;
- TQueryGlobals query_globals;
+ TUniqueId _unique_id;
+ TQueryOptions _query_options;
+ TQueryGlobals _query_globals;
+ std::shared_ptr<NewFileScanNode> _scan_node = nullptr;
+ std::vector<TFileRangeDesc> _ranges;
+ TFileRangeDesc _range_desc;
+ TFileScanRange _scan_range;
+ std::unique_ptr<ShardedKVCache> _kv_cache = nullptr;
+ std::unique_ptr<TMasterInfo> _master_info = nullptr;
};
-void VWalScannerTest::init_desc_table() {
+void VWalScannerTest::_init_desc_table() {
Review Comment:
warning: function '_init_desc_table' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
void VWalScannerTest::_init_desc_table() {
^
```
<details>
<summary>Additional context</summary>
**be/test/vec/exec/vwal_scanner_test.cpp:91:** 117 lines including
whitespace and comments (threshold 80)
```cpp
void VWalScannerTest::_init_desc_table() {
^
```
</details>
##########
be/test/vec/exec/vwal_scanner_test.cpp:
##########
@@ -73,12 +78,18 @@ class VWalScannerTest : public testing::Test {
ScannerCounter _counter;
std::vector<TExpr> _pre_filter;
TPlanNode _tnode;
- TUniqueId unique_id;
- TQueryOptions query_options;
- TQueryGlobals query_globals;
+ TUniqueId _unique_id;
+ TQueryOptions _query_options;
+ TQueryGlobals _query_globals;
+ std::shared_ptr<NewFileScanNode> _scan_node = nullptr;
+ std::vector<TFileRangeDesc> _ranges;
+ TFileRangeDesc _range_desc;
+ TFileScanRange _scan_range;
+ std::unique_ptr<ShardedKVCache> _kv_cache = nullptr;
+ std::unique_ptr<TMasterInfo> _master_info = nullptr;
};
-void VWalScannerTest::init_desc_table() {
+void VWalScannerTest::_init_desc_table() {
Review Comment:
warning: method '_init_desc_table' can be made static
[readability-convert-member-functions-to-static]
be/test/vec/exec/vwal_scanner_test.cpp:60:
```diff
- void _init_desc_table();
+ static void _init_desc_table();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
