Re: [PR] [pick][improvement](jdbc catalog) Optimize connection pool parameter settings [doris]

[via GitHub]

github-actions[bot] commented on code in PR #31177:
URL: https://github.com/apache/doris/pull/31177#discussion_r1496069275


##########
be/src/runtime/descriptors.h:
##########
@@ -307,6 +307,7 @@ class JdbcTableDescriptor : public TableDescriptor {
 public:
     JdbcTableDescriptor(const TTableDescriptor& tdesc);
     std::string debug_string() const override;
+    int64_t jdbc_catalog_id() const { return _jdbc_catalog_id; }

Review Comment:
   warning: function 'jdbc_catalog_id' should be marked [[nodiscard]] 
[modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] int64_t jdbc_catalog_id() const { return _jdbc_catalog_id; 
}
   ```
   



##########
be/src/runtime/descriptors.h:
##########
@@ -315,8 +316,14 @@
     const std::string& jdbc_table_name() const { return _jdbc_table_name; }
     const std::string& jdbc_user() const { return _jdbc_user; }
     const std::string& jdbc_passwd() const { return _jdbc_passwd; }
+    int32_t connection_pool_min_size() const { return 
_connection_pool_min_size; }
+    int32_t connection_pool_max_size() const { return 
_connection_pool_max_size; }
+    int32_t connection_pool_max_wait_time() const { return 
_connection_pool_max_wait_time; }

Review Comment:
   warning: function 'connection_pool_max_wait_time' should be marked 
[[nodiscard]] [modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] int32_t connection_pool_max_wait_time() const { return 
_connection_pool_max_wait_time; }
   ```
   



##########
be/src/runtime/descriptors.h:
##########
@@ -315,8 +316,14 @@
     const std::string& jdbc_table_name() const { return _jdbc_table_name; }
     const std::string& jdbc_user() const { return _jdbc_user; }
     const std::string& jdbc_passwd() const { return _jdbc_passwd; }
+    int32_t connection_pool_min_size() const { return 
_connection_pool_min_size; }

Review Comment:
   warning: function 'connection_pool_min_size' should be marked [[nodiscard]] 
[modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] int32_t connection_pool_min_size() const { return 
_connection_pool_min_size; }
   ```
   



##########
be/src/runtime/descriptors.h:
##########
@@ -315,8 +316,14 @@
     const std::string& jdbc_table_name() const { return _jdbc_table_name; }
     const std::string& jdbc_user() const { return _jdbc_user; }
     const std::string& jdbc_passwd() const { return _jdbc_passwd; }
+    int32_t connection_pool_min_size() const { return 
_connection_pool_min_size; }
+    int32_t connection_pool_max_size() const { return 
_connection_pool_max_size; }
+    int32_t connection_pool_max_wait_time() const { return 
_connection_pool_max_wait_time; }
+    int32_t connection_pool_max_life_time() const { return 
_connection_pool_max_life_time; }

Review Comment:
   warning: function 'connection_pool_max_life_time' should be marked 
[[nodiscard]] [modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] int32_t connection_pool_max_life_time() const { return 
_connection_pool_max_life_time; }
   ```
   



##########
be/src/runtime/descriptors.h:
##########
@@ -315,8 +316,14 @@
     const std::string& jdbc_table_name() const { return _jdbc_table_name; }
     const std::string& jdbc_user() const { return _jdbc_user; }
     const std::string& jdbc_passwd() const { return _jdbc_passwd; }
+    int32_t connection_pool_min_size() const { return 
_connection_pool_min_size; }
+    int32_t connection_pool_max_size() const { return 
_connection_pool_max_size; }

Review Comment:
   warning: function 'connection_pool_max_size' should be marked [[nodiscard]] 
[modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] int32_t connection_pool_max_size() const { return 
_connection_pool_max_size; }
   ```
   



##########
be/src/runtime/descriptors.h:
##########
@@ -315,8 +316,14 @@
     const std::string& jdbc_table_name() const { return _jdbc_table_name; }
     const std::string& jdbc_user() const { return _jdbc_user; }
     const std::string& jdbc_passwd() const { return _jdbc_passwd; }
+    int32_t connection_pool_min_size() const { return 
_connection_pool_min_size; }
+    int32_t connection_pool_max_size() const { return 
_connection_pool_max_size; }
+    int32_t connection_pool_max_wait_time() const { return 
_connection_pool_max_wait_time; }
+    int32_t connection_pool_max_life_time() const { return 
_connection_pool_max_life_time; }
+    bool connection_pool_keep_alive() const { return 
_connection_pool_keep_alive; }

Review Comment:
   warning: function 'connection_pool_keep_alive' should be marked 
[[nodiscard]] [modernize-use-nodiscard]
   
   ```suggestion
       [[nodiscard]] bool connection_pool_keep_alive() const { return 
_connection_pool_keep_alive; }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org