zclllyybb commented on code in PR #31163: URL: https://github.com/apache/doris/pull/31163#discussion_r1495570526
########## be/src/vec/columns/column_array.cpp: ########## @@ -291,11 +291,6 @@ void ColumnArray::update_hash_with_value(size_t n, SipHash& hash) const { for (size_t i = 0; i < array_size; ++i) get_data().update_hash_with_value(offset + i, hash); } -void ColumnArray::update_hashes_with_value(std::vector<SipHash>& hashes, - const uint8_t* __restrict null_data) const { - SIP_HASHES_FUNCTION_COLUMN_IMPL(); Review Comment: check if it's safe to delete this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org