github-actions[bot] commented on code in PR #31142:
URL: https://github.com/apache/doris/pull/31142#discussion_r1495324059


##########
be/src/vec/functions/match.h:
##########
@@ -159,6 +159,23 @@ class FunctionMatchRegexp : public FunctionMatchBase {
     }
 };
 
+class FunctionMatchPhraseEdge : public FunctionMatchBase {
+public:
+    static constexpr auto name = "match_phrase_edge";
+    static FunctionPtr create() { return 
std::make_shared<FunctionMatchPhraseEdge>(); }
+
+    String get_name() const override { return name; }
+
+    Status execute_match(const std::string& column_name, const std::string& 
match_query_str,

Review Comment:
   warning: method 'execute_match' can be made static 
[readability-convert-member-functions-to-static]
   
   ```suggestion
       static Status execute_match(const std::string& column_name, const 
std::string& match_query_str,
   ```
   
   be/src/vec/functions/match.h:172:
   ```diff
   -                          ColumnUInt8::Container& result) const override {
   +                          ColumnUInt8::Container& result) override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to