github-actions[bot] commented on code in PR #31141:
URL: https://github.com/apache/doris/pull/31141#discussion_r1495294990
##########
be/src/olap/row_cursor.cpp:
##########
@@ -137,7 +138,7 @@ Status RowCursor::init(TabletSchemaSPtr schema) {
return init(schema->columns(), schema->num_columns());
}
-Status RowCursor::init(const std::vector<TabletColumn>& schema) {
+Status RowCursor::init(const std::vector<TabletColumnPtr>& schema) {
Review Comment:
warning: method 'init' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RowCursor::init(const std::vector<TabletColumnPtr>& schema) {
```
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -333,12 +333,12 @@ Status Segment::_load_index_impl() {
// Return the storage datatype of related column to field.
// Return nullptr meaning no such storage infomation for this column
-vectorized::DataTypePtr Segment::get_data_type_of(vectorized::PathInData path,
bool is_nullable,
+vectorized::DataTypePtr Segment::get_data_type_of(vectorized::PathInDataPtr
path, bool is_nullable,
Review Comment:
warning: method 'get_data_type_of' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_v2/segment.cpp:336:
```diff
- bool ignore_children)
const {
+ bool ignore_children) {
```
be/src/olap/rowset/segment_v2/segment.h:155:
```diff
- std::shared_ptr<const vectorized::IDataType>
get_data_type_of(vectorized::PathInDataPtr path,
+ static std::shared_ptr<const vectorized::IDataType>
get_data_type_of(vectorized::PathInDataPtr path,
```
be/src/olap/rowset/segment_v2/segment.h:157:
```diff
- bool
ignore_children) const;
+ bool
ignore_children) ;
```
##########
be/src/olap/row_cursor.cpp:
##########
@@ -157,7 +158,7 @@
return Status::OK();
}
-Status RowCursor::init(const std::vector<TabletColumn>& schema, size_t
column_count) {
+Status RowCursor::init(const std::vector<TabletColumnPtr>& schema, size_t
column_count) {
Review Comment:
warning: method 'init' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RowCursor::init(const std::vector<TabletColumnPtr>& schema,
size_t column_count) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
