Nitin-Kashyap commented on code in PR #27784:
URL: https://github.com/apache/doris/pull/27784#discussion_r1494651176
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/DistributionSpecHash.java:
##########
@@ -54,6 +54,8 @@ public class DistributionSpecHash extends DistributionSpec {
private final Set<Long> partitionIds;
private final long selectedIndexId;
+ private final ShuffleFunction shuffleFunction;
Review Comment:
I need to add multiple sub types for shuffle type indicating hash functions
for it (doris use crc32, spark use murmr32, hive v1, v2, hudi-hash all these
are different).
and for each if I add a separate shuffle type then `ChildPropertiesRegulator
. visitPhysicalHashJoin()` will become too bloated.
@morrySnow Can you please suggest a better way to handle the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
