github-actions[bot] commented on PR #31126:
URL: https://github.com/apache/doris/pull/31126#issuecomment-1952447843
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/7960253387";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/ssb-tools/bin/load-ssb-data.sh line 342:
local FILE_ID="${@//*.}"
^--------^ SC2124 (warning): Assigning an array to a
string! Assign as array, or use * instead of @ to concatenate.
In tools/tpch-tools/bin/load-tpch-data.sh line 192:
local FILE_ID="${@//*.}"
^--------^ SC2124 (warning): Assigning an array to a
string! Assign as array, or use * instead of @ to concatenate.
In tools/tpch-tools/bin/load-tpch-data.sh line 206:
local FILE_ID="${@//*.}"
^--------^ SC2124 (warning): Assigning an array to a
string! Assign as array, or use * instead of @ to concatenate.
In tools/tpch-tools/bin/load-tpch-data.sh line 220:
local FILE_ID="${@//*.}"
^--------^ SC2124 (warning): Assigning an array to a
string! Assign as array, or use * instead of @ to concatenate.
For more information:
https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string!
A...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/ssb-tools/bin/load-ssb-data.sh.orig
+++ tools/ssb-tools/bin/load-ssb-data.sh
@@ -339,7 +339,7 @@
function load() {
echo "$@"
# shellcheck disable=SC2016
- local FILE_ID="${@//*.}"
+ local FILE_ID="${@//*./}"
if [[ -z ${TXN_ID} ]]; then
curl --location-trusted -u "${USER}":"${PASSWORD}" \
-H "column_separator:|" \
--- tools/tpch-tools/bin/load-tpch-data.sh.orig
+++ tools/tpch-tools/bin/load-tpch-data.sh
@@ -189,7 +189,7 @@
function load_partsupp() {
echo "$*"
# shellcheck disable=SC2016
- local FILE_ID="${@//*.}"
+ local FILE_ID="${@//*./}"
if [[ -z ${TXN_ID} ]]; then
curl -s --location-trusted -u "${USER}":"${PASSWORD}" -H
"column_separator:|" \
-H "columns: ps_partkey, ps_suppkey, ps_availqty,
ps_supplycost, ps_comment, temp" \
@@ -203,7 +203,7 @@
}
function load_orders() {
echo "$*"
- local FILE_ID="${@//*.}"
+ local FILE_ID="${@//*./}"
if [[ -z ${TXN_ID} ]]; then
curl -s --location-trusted -u "${USER}":"${PASSWORD}" -H
"column_separator:|" \
-H "columns: o_orderkey, o_custkey, o_orderstatus,
o_totalprice, o_orderdate, o_orderpriority, o_clerk, o_shippriority, o_comment,
temp" \
@@ -217,7 +217,7 @@
}
function load_lineitem() {
echo "$*"
- local FILE_ID="${@//*.}"
+ local FILE_ID="${@//*./}"
if [[ -z ${TXN_ID} ]]; then
curl -s --location-trusted -u "${USER}":"${PASSWORD}" -H
"column_separator:|" \
-H "columns: l_orderkey, l_partkey, l_suppkey, l_linenumber,
l_quantity, l_extendedprice, l_discount, l_tax, l_returnflag,l_linestatus,
l_shipdate,l_commitdate,l_receiptdate,l_shipinstruct,l_shipmode,l_comment,temp"
\
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
