github-actions[bot] commented on code in PR #31122:
URL: https://github.com/apache/doris/pull/31122#discussion_r1494433372
##########
be/src/olap/lru_cache.h:
##########
@@ -408,8 +414,9 @@ class ShardedLRUCache : public Cache {
virtual void* value(Handle* handle) override;
Slice value_slice(Handle* handle) override;
virtual uint64_t new_id() override;
- virtual int64_t prune() override;
- int64_t prune_if(CacheValuePredicate pred, bool lazy_mode = false)
override;
+ virtual int64_t prune(int64_t* freed_size) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
int64_t prune(int64_t* freed_size) override;
```
##########
be/src/olap/lru_cache.h:
##########
@@ -479,8 +486,11 @@
void* value(Handle* handle) override;
Slice value_slice(Handle* handle) override;
uint64_t new_id() override { return 0; };
- int64_t prune() override { return 0; };
- int64_t prune_if(CacheValuePredicate pred, bool lazy_mode = false)
override { return 0; };
+ int64_t prune(int64_t* freed_size) override { return 0; };
+ int64_t prune_if(CachePrunePredicate pred, int64_t* freed_size,
Review Comment:
warning: method 'prune_if' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static int64_t prune_if(CachePrunePredicate pred, int64_t* freed_size,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
