(doris) 04/18: [fix](repository) fix NullPointerException when execute create repository statement without properties (#30972)

[yiguolei]

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 3f126fdd6302590290dcb2bc5dc5c4efc2c296db
Author: caiconghui <55968745+caicong...@users.noreply.github.com>
AuthorDate: Sun Feb 18 16:33:41 2024 +0800

    [fix](repository) fix NullPointerException when execute create repository 
statement without properties (#30972)
    
    Co-authored-by: caiconghui1 <caicongh...@jd.com>
---
 fe/fe-core/src/main/cup/sql_parser.cup                                | 4 ++--
 .../src/main/java/org/apache/doris/analysis/RefreshCatalogStmt.java   | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/fe/fe-core/src/main/cup/sql_parser.cup 
b/fe/fe-core/src/main/cup/sql_parser.cup
index 3893343ebb7..ec3bba7996b 100644
--- a/fe/fe-core/src/main/cup/sql_parser.cup
+++ b/fe/fe-core/src/main/cup/sql_parser.cup
@@ -3505,7 +3505,7 @@ key_value_map ::=
 
 opt_properties ::=
     {:
-    RESULT = null;
+    RESULT = Maps.newHashMap();
     :}
     | properties:properties
     {:
@@ -3644,7 +3644,7 @@ opt_actions ::=
 
 opt_ext_properties ::=
     {:
-    RESULT = null;
+    RESULT = Maps.newHashMap();
     :}
     | KW_BROKER properties:properties
     {:
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/RefreshCatalogStmt.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/RefreshCatalogStmt.java
index 006eebe44b3..a2e5930d142 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/RefreshCatalogStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/RefreshCatalogStmt.java
@@ -73,7 +73,8 @@ public class RefreshCatalogStmt extends DdlStmt {
         }
 
         // Set to false only if user set the property "invalid_cache"="false"
-        invalidCache = !(properties != null && 
properties.get(INVALID_CACHE).equalsIgnoreCase("false"));
+        invalidCache = !(properties.get(INVALID_CACHE) != null && 
properties.get(INVALID_CACHE)
+                .equalsIgnoreCase("false"));
     }
 
     @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org