zclllyybb commented on code in PR #30991:
URL: https://github.com/apache/doris/pull/30991#discussion_r1483299619
##########
be/src/agent/be_exec_version_manager.h:
##########
@@ -65,6 +65,7 @@ class BeExecVersionManager {
* d. unix_timestamp function support timestamp with float for datetimev2,
and change nullable mode.
* e. change shuffle serialize/deserialize way
* f. the right function outputs NULL when the function contains NULL,
substr function returns empty if start > str.length, and change some function
nullable mode.
+ * g. function to_base64, from_base64 will return empty string when input
empty string.
Review Comment:
please combine f and g to shorter words. just like "shrink some function's
nullable mode"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
