xinyiZzz commented on code in PR #30817:
URL: https://github.com/apache/doris/pull/30817#discussion_r1478498210
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -3250,7 +3252,17 @@ public Object visitCallProcedure(CallProcedureContext
ctx) {
List<Expression> arguments = ctx.expression().stream()
.<Expression>map(this::typedVisit)
.collect(ImmutableList.toImmutableList());
- UnboundFunction unboundFunction = new UnboundFunction(functionName,
arguments);
+ UnboundFunction unboundFunction = new UnboundFunction(functionName,
arguments, getOriginSql(ctx));
Review Comment:
`Procedure`, `Function`, `Package` have very similar syntax, the difference
is that `Function` has `Return`, etc.
In Hive, `Procedure` and `Function` share the same set of `FunctionRegistry`
interfaces.
In Oracle, their syntax is also very similar.
————————————————————————
Of course, now for minimal code modifications.
The code structure between `Procedure`, `Function`, `built-in Function`, and
`Package` will be further considered later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
