github-actions[bot] commented on code in PR #30829:
URL: https://github.com/apache/doris/pull/30829#discussion_r1478299576
##########
be/src/runtime/query_context.cpp:
##########
@@ -177,4 +203,17 @@ ThreadPool* QueryContext::get_non_pipe_exec_thread_pool() {
}
}
+void QueryContext::set_task_group(taskgroup::TaskGroupPtr& tg) {
+ if (tg->is_shutdown()) {
+ // The task group is marked shutdown, then should not put query task
Review Comment:
warning: method 'set_task_group' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/query_context.h:152:
```diff
- void set_task_group(taskgroup::TaskGroupPtr& tg);
+ static void set_task_group(taskgroup::TaskGroupPtr& tg);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
