yiguolei commented on code in PR #30746:
URL: https://github.com/apache/doris/pull/30746#discussion_r1477918124
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -246,31 +244,16 @@ Status VScanNode::get_next(RuntimeState* state,
vectorized::Block* block, bool*
}};
if (state->is_cancelled()) {
- // ISSUE: https://github.com/apache/doris/issues/16360
- // _scanner_ctx may be null here, see: `VScanNode::alloc_resource`
(_eos == null)
- if (_scanner_ctx) {
- _scanner_ctx->set_status_on_error(Status::Cancelled("query
cancelled"));
- return _scanner_ctx->status();
- } else {
- return Status::Cancelled("query cancelled");
- }
+ _scanner_ctx->stop_scanners(state);
Review Comment:
_scanner_ctx maybe is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
