github-actions[bot] commented on code in PR #30829:
URL: https://github.com/apache/doris/pull/30829#discussion_r1477576434
##########
be/src/runtime/task_group/task_group_manager.h:
##########
@@ -69,9 +69,19 @@ class TaskGroupManager {
vectorized::SimplifiedScanScheduler** scan_sched,
ThreadPool** non_pipe_thread_pool);
- Status add_query_to_group(uint64_t tg_id, TUniqueId query_id,
TaskGroupPtr* tg_ptr);
-
- void remove_query_from_group(uint64_t tg_id, TUniqueId query_id);
+ TaskGroupPtr get_task_group(uint64_t tg_id) {
Review Comment:
warning: method 'get_task_group' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static TaskGroupPtr get_task_group(uint64_t tg_id) {
```
##########
be/src/runtime/query_context.h:
##########
@@ -219,12 +209,12 @@ class QueryContext {
std::shared_ptr<QueryStatistics> get_cpu_statistics() { return
_cpu_statistics; }
- void set_query_scheduler(uint64_t wg_id);
-
doris::pipeline::TaskScheduler* get_pipe_exec_scheduler();
ThreadPool* get_non_pipe_exec_thread_pool();
+ int64_t mem_limit() { return _bytes_limit; }
Review Comment:
warning: method 'mem_limit' can be made const
[readability-make-member-function-const]
```suggestion
int64_t mem_limit() const { return _bytes_limit; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
