github-actions[bot] commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477332320
##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,48 @@ class FunctionStringParseUrl : public IFunction {
}
};
+class FunctionUrlDecode : public IFunction {
+public:
+ static constexpr auto name = "url_decode";
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block,
Review Comment:
warning: method 'execute_impl' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status execute_impl(FunctionContext* context, Block& block,
```
be/src/vec/functions/function_string.h:2753:
```diff
- size_t input_rows_count) const override {
+ size_t input_rows_count) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
