AshinGau commented on code in PR #30746:
URL: https://github.com/apache/doris/pull/30746#discussion_r1477308048
##########
be/src/pipeline/exec/file_scan_operator.cpp:
##########
@@ -62,7 +64,7 @@ void FileScanLocalState::set_scan_ranges(RuntimeState* state,
const std::vector<TScanRangeParams>&
scan_ranges) {
int max_scanners =
config::doris_scanner_thread_pool_thread_num /
state->query_parallel_instance_num();
- max_scanners = max_scanners == 0 ? 1 : max_scanners;
+ max_scanners = std::max(std::max(max_scanners,
state->parallel_scan_max_scanners_count()), 1);
Review Comment:
As mentioned earlier, some scanners may have long tails and require an
increase in the number of scanners. Previously, it was not obvious because the
blocks were shared, and long tailed scanners can read multiple blocks at once.
Currently, only one block can be read, making the problem more serious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
