github-actions[bot] commented on code in PR #30804:
URL: https://github.com/apache/doris/pull/30804#discussion_r1477202300
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -608,7 +609,8 @@ void BetaRowsetWriter::_build_rowset_meta_with_spec_field(
rowset_meta->set_segments_key_bounds(segments_key_bounds);
}
-void BetaRowsetWriter::_build_rowset_meta(std::shared_ptr<RowsetMeta>
rowset_meta) {
+void BetaRowsetWriter::_build_rowset_meta(std::shared_ptr<RowsetMeta>
rowset_meta,
Review Comment:
warning: method '_build_rowset_meta' can be made const
[readability-make-member-function-const]
be/src/olap/rowset/beta_rowset_writer.cpp:612:
```diff
- bool check_segment_num) {
+ bool check_segment_num) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
