github-actions[bot] commented on code in PR #30801:
URL: https://github.com/apache/doris/pull/30801#discussion_r1477195835
##########
be/src/exec/decompressor.cpp:
##########
@@ -67,6 +68,78 @@
return st;
}
+Status Decompressor::create_decompressor(TFileCompressType::type type,
Decompressor** decompressor) {
+ CompressType compress_type;
+ switch (type) {
+ case TFileCompressType::PLAIN:
+ compress_type = CompressType::UNCOMPRESSED;
+ break;
+ case TFileCompressType::GZ:
+ compress_type = CompressType::GZIP;
+ break;
+ case TFileCompressType::LZO:
+ compress_type = CompressType::LZOP;
+ break;
+ case TFileCompressType::BZ2:
+ compress_type = CompressType::BZIP2;
+ break;
+ case TFileCompressType::LZ4FRAME:
+ compress_type = CompressType::LZ4FRAME;
+ break;
+ case TFileCompressType::LZ4BLOCK:
+ compress_type = CompressType::LZ4BLOCK;
+ break;
+ case TFileCompressType::DEFLATE:
+ compress_type = CompressType::DEFLATE;
+ break;
+ case TFileCompressType::SNAPPYBLOCK:
+ compress_type = CompressType::SNAPPYBLOCK;
+ break;
+ default:
+ return Status::InternalError<false>("unknown compress type: {}", type);
+ }
+ RETURN_IF_ERROR(Decompressor::create_decompressor(compress_type,
decompressor));
+
+ return Status::OK();
+}
+
+Status Decompressor::create_decompressor(TFileFormatType::type type,
Decompressor** decompressor) {
Review Comment:
warning: method 'create_decompressor' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status Decompressor::create_decompressor(TFileFormatType::type type,
Decompressor** decompressor) {
```
##########
be/src/exec/decompressor.cpp:
##########
@@ -67,6 +68,78 @@ Status Decompressor::create_decompressor(CompressType type,
Decompressor** decom
return st;
}
+Status Decompressor::create_decompressor(TFileCompressType::type type,
Decompressor** decompressor) {
Review Comment:
warning: method 'create_decompressor' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status Decompressor::create_decompressor(TFileCompressType::type
type, Decompressor** decompressor) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
