github-actions[bot] commented on code in PR #30730:
URL: https://github.com/apache/doris/pull/30730#discussion_r1477184692
##########
be/src/vec/functions/function_ip.h:
##########
@@ -360,8 +369,8 @@ class FunctionIPv6NumToString : public IFunction {
namespace detail {
template <IPConvertExceptionMode exception_mode, typename ToColumn =
ColumnIPv6,
typename StringColumnType>
-ColumnPtr convertToIPv6(const StringColumnType& string_column,
- const PaddedPODArray<UInt8>* null_map = nullptr) {
+ColumnPtr convert_to_ipv6(const StringColumnType& string_column,
Review Comment:
warning: function 'convert_to_ipv6' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
ColumnPtr convert_to_ipv6(const StringColumnType& string_column,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/function_ip.h:371:** 144 lines including whitespace
and comments (threshold 80)
```cpp
ColumnPtr convert_to_ipv6(const StringColumnType& string_column,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
