morrySnow commented on code in PR #27784:
URL: https://github.com/apache/doris/pull/27784#discussion_r1475593689
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -318,7 +320,8 @@ public PlanFragment
visitPhysicalDistribute(PhysicalDistribute<? extends Plan> d
dataStreamSink.setOutputTupleDesc(projectionTuple);
}
}
- DataPartition dataPartition =
toDataPartition(distribute.getDistributionSpec(), validOutputIds, context);
+ DataPartition dataPartition =
toDataPartition(distribute.getDistributionSpec(), validOutputIds, context,
Review Comment:
do u test, bucket shuffle join with left table is olap table and right table
is a bucketed hive table?
i think the result will be wrong because right table will be shuffled by
spark hash and left table is distributed by Doris hash.
i think the right way to do this in Nereids should add a new ShuffleType in
DistributionSpecHash, and generate PhysicalDistribute with **RIGHT**
ShuffleType when adding enforcer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
