github-actions[bot] commented on code in PR #30729:
URL: https://github.com/apache/doris/pull/30729#discussion_r1474706103
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -433,6 +462,53 @@ Status SegmentIterator::_get_row_ranges_by_keys() {
return Status::OK();
}
+Status SegmentIterator::_prepare_seek(const StorageReadOptions::SplitKeyRange&
key_range) {
Review Comment:
warning: method '_prepare_seek' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_v2/segment_iterator.h:165:
```diff
- [[nodiscard]] Status _prepare_seek(const
StorageReadOptions::SplitKeyRange& key_range);
+ [[nodiscard]] static Status _prepare_seek(const
StorageReadOptions::SplitKeyRange& key_range);
```
##########
be/src/olap/parallel_scanner_builder.cpp:
##########
@@ -159,6 +168,142 @@ Status
ParallelScannerBuilder<ParentType>::_build_scanners_by_rowid(
return Status::OK();
}
+template <typename ParentType>
+Status ParallelScannerBuilder<ParentType>::_build_scanners_by_key_range(
Review Comment:
warning: function '_build_scanners_by_key_range' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status ParallelScannerBuilder<ParentType>::_build_scanners_by_key_range(
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/parallel_scanner_builder.cpp:171:** 132 lines including
whitespace and comments (threshold 80)
```cpp
Status ParallelScannerBuilder<ParentType>::_build_scanners_by_key_range(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
