morningman commented on code in PR #30588:
URL: https://github.com/apache/doris/pull/30588#discussion_r1474695876
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcTable.java:
##########
@@ -63,6 +64,11 @@ public class JdbcTable extends Table {
private static final String DRIVER_CLASS = "driver_class";
private static final String DRIVER_URL = "driver_url";
private static final String CHECK_SUM = "checksum";
+ private static final String CONNECTION_POOL_MIN_SIZE =
"connection_pool_min_size";
Review Comment:
Already defined in `JdbcResource`?
##########
fe/fe-core/src/test/java/org/apache/doris/catalog/JdbcResourceTest.java:
##########
@@ -49,7 +190,8 @@ public void testHandleJdbcUrlForSqlServerWithoutParams()
throws DdlException {
@Test
public void testHandleJdbcUrlForSqlServerWithParams() throws DdlException {
- String inputUrl =
"jdbc:sqlserver://43.129.237.12:1433;encrypt=false;databaseName=doris_test;trustServerCertificate=false";
+ String inputUrl
+ =
"jdbc:sqlserver://43.129.237.12:1433;encrypt=false;databaseName=doris_test;trustServerCertificate=false";
Review Comment:
change ip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
