github-actions[bot] commented on code in PR #30717: URL: https://github.com/apache/doris/pull/30717#discussion_r1474343422
########## be/src/vec/runtime/vdata_stream_recvr.cpp: ########## @@ -409,12 +407,9 @@ Status VDataStreamRecvr::get_next(Block* block, bool* eos) { } } -void VDataStreamRecvr::remove_sender(int sender_id, int be_number, QueryStatisticsPtr statistics) { +void VDataStreamRecvr::remove_sender(int sender_id, int be_number) { Review Comment: warning: method 'remove_sender' can be made const [readability-make-member-function-const] ```suggestion void VDataStreamRecvr::remove_sender(int sender_id, int be_number) const { ``` be/src/vec/runtime/vdata_stream_recvr.h:92: ```diff - void remove_sender(int sender_id, int be_number); + void remove_sender(int sender_id, int be_number) const; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org