weizuo93 commented on a change in pull request #5781:
URL: https://github.com/apache/incubator-doris/pull/5781#discussion_r698519765
##########
File path: be/src/util/threadpool.cpp
##########
@@ -610,6 +607,47 @@ void ThreadPool::check_not_pool_thread_unlocked() {
}
}
+Status ThreadPool::set_min_threads(int min_threads) {
+ if (min_threads <= _max_threads) {
+ _min_threads = min_threads;
Review comment:
> Even though `_min_threads` is type of `AtomicInt32`, this function is
not thread safe.
You're right, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
