github-actions[bot] commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1472901807
##########
be/src/vec/functions/function_string.h:
##########
@@ -2602,6 +2603,57 @@
}
};
+class FunctionUrlDecode : public IFunction {
+public:
+ static constexpr auto name = "url_decode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlDecode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+ bool use_default_implementation_for_nulls() const override { return true; }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const
override {
Review Comment:
warning: method 'execute_impl' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
size_t result, size_t input_rows_count) override
{
```
##########
be/src/vec/functions/function_string.h:
##########
@@ -2602,6 +2603,57 @@ class FunctionStringParseUrl : public IFunction {
}
};
+class FunctionUrlDecode : public IFunction {
+public:
+ static constexpr auto name = "url_decode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlDecode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
Review Comment:
warning: method 'get_return_type_impl' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypePtr get_return_type_impl(const DataTypes& arguments)
override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
