github-actions[bot] commented on code in PR #30598:
URL: https://github.com/apache/doris/pull/30598#discussion_r1471107096
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -657,19 +659,20 @@ void
BaseBetaRowsetWriter::_build_rowset_meta(std::shared_ptr<RowsetMeta> rowset
}
}
-RowsetSharedPtr BaseBetaRowsetWriter::_build_tmp() {
- std::shared_ptr<RowsetMeta> rowset_meta_ = std::make_shared<RowsetMeta>();
+Status BaseBetaRowsetWriter::_build_tmp(RowsetSharedPtr& rowset_ptr) {
Review Comment:
warning: method '_build_tmp' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/beta_rowset_writer.h:143:
```diff
- Status _build_tmp(RowsetSharedPtr& rowset_ptr);
+ static Status _build_tmp(RowsetSharedPtr& rowset_ptr);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
