zenoyang commented on pull request #6448: URL: https://github.com/apache/incubator-doris/pull/6448#issuecomment-906167308
> Your implementation can ensure consistency, but this approach is a bit complicated. We should minimize unnecessary state maintenance. > > So I suggest to follow the logic of `labelCleaner`, and each FE cleans up its own deleteInfo. Regarding the issue of consistency, you can forward the `show delete` statement to the master FE for execution, so that we can get consistent results. > > Regarding the forwarding logic, you can refer to the `getRedirectStatus` method of `ShowLoadStmt.java` Thank you Mingyu for your suggestion. I have submitted a new version of the code: each FE cleans up own deleteInfo, and forwards the show delete statement to the master FE for execution. Please review it again, thank you everyone ^_^ @morningman @xy720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
