zclllyybb commented on code in PR #30557: URL: https://github.com/apache/doris/pull/30557#discussion_r1470725487
########## be/src/vec/functions/like.cpp: ########## @@ -320,6 +319,53 @@ Status FunctionLikeBase::hs_prepare(FunctionContext* context, const char* expres return Status::OK(); } +static Status execute_substring(const ColumnString::Chars& values, Review Comment: basically yes, change it from member function to static function in this file cuz no need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org