github-actions[bot] commented on code in PR #28872:
URL: https://github.com/apache/doris/pull/28872#discussion_r1470526169
##########
be/src/olap/rowset/beta_rowset.cpp:
##########
@@ -338,7 +339,8 @@ Status BetaRowset::copy_files_to(const std::string& dir,
const RowsetId& new_row
return Status::OK();
}
-Status BetaRowset::upload_to(io::RemoteFileSystem* dest_fs, const RowsetId&
new_rowset_id) {
+Status BetaRowset::upload_to(const io::RemoteFileSystemSPtr& dest_fs,
Review Comment:
warning: function 'upload_to' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status BetaRowset::upload_to(const io::RemoteFileSystemSPtr& dest_fs,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/beta_rowset.cpp:341:** 83 lines including whitespace
and comments (threshold 80)
```cpp
Status BetaRowset::upload_to(const io::RemoteFileSystemSPtr& dest_fs,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
