This is an automated email from the ASF dual-hosted git repository.
zhangchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a2a6f9a3989 [enhancement](log) print detail error for segment
compaction failure (#30503)
a2a6f9a3989 is described below
commit a2a6f9a398974ea3bef9248d5cb6c1856f8d16bd
Author: zhannngchen <48427519+zhannngc...@users.noreply.github.com>
AuthorDate: Tue Jan 30 09:48:51 2024 +0800
[enhancement](log) print detail error for segment compaction failure
(#30503)
---
be/src/olap/rowset/beta_rowset_writer.cpp | 11 ++++++++---
be/src/olap/rowset/segcompaction.cpp | 3 ++-
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/be/src/olap/rowset/beta_rowset_writer.cpp
b/be/src/olap/rowset/beta_rowset_writer.cpp
index 1f878dc4674..40db1bd5932 100644
--- a/be/src/olap/rowset/beta_rowset_writer.cpp
+++ b/be/src/olap/rowset/beta_rowset_writer.cpp
@@ -396,7 +396,8 @@ Status BetaRowsetWriter::_segcompaction_if_necessary() {
}
if (_segcompaction_status.load() != OK) {
status = Status::Error<SEGCOMPACTION_FAILED>(
- "BetaRowsetWriter::_segcompaction_if_necessary meet invalid
state");
+ "BetaRowsetWriter::_segcompaction_if_necessary meet invalid
state, error code: {}",
+ _segcompaction_status.load());
} else if ((_num_segment - _segcompacted_point) >=
config::segcompaction_batch_size) {
SegCompactionCandidatesSharedPtr segments;
status = _find_longest_consecutive_small_segment(segments);
@@ -425,7 +426,9 @@ Status
BetaRowsetWriter::_segcompaction_rename_last_segments() {
}
if (_segcompaction_status.load() != OK) {
return Status::Error<SEGCOMPACTION_FAILED>(
- "BetaRowsetWriter::_segcompaction_rename_last_segments meet
invalid state");
+ "BetaRowsetWriter::_segcompaction_rename_last_segments meet
invalid state, error "
+ "code: {}",
+ _segcompaction_status.load());
}
if (!_is_segcompacted() || _segcompacted_point == _num_segment) {
// no need if never segcompact before or all segcompacted
@@ -501,7 +504,9 @@ Status BetaRowsetWriter::_wait_flying_segcompaction() {
LOG(INFO) << "wait flying segcompaction finish time:" << elapsed <<
"us";
}
if (_segcompaction_status.load() != OK) {
- return Status::Error<SEGCOMPACTION_FAILED>("BetaRowsetWriter meet
invalid state.");
+ return Status::Error<SEGCOMPACTION_FAILED>(
+ "BetaRowsetWriter meet invalid state, error code: {}",
+ _segcompaction_status.load());
}
return Status::OK();
}
diff --git a/be/src/olap/rowset/segcompaction.cpp
b/be/src/olap/rowset/segcompaction.cpp
index d21efbd7e23..e252870ae76 100644
--- a/be/src/olap/rowset/segcompaction.cpp
+++ b/be/src/olap/rowset/segcompaction.cpp
@@ -241,7 +241,8 @@ Status
SegcompactionWorker::_do_compact_segments(SegCompactionCandidatesSharedPt
auto s = _get_segcompaction_reader(segments, tablet, schema,
&reader_stats, row_sources_buf,
is_key, column_ids, &reader);
if (UNLIKELY(reader == nullptr || !s.ok())) {
- return Status::Error<SEGCOMPACTION_INIT_READER>("failed to get
segcompaction reader.");
+ return Status::Error<SEGCOMPACTION_INIT_READER>(
+ "failed to get segcompaction reader. err: {}",
s.to_string());
}
Merger::Statistics merger_stats;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
