morningman commented on code in PR #30514:
URL: https://github.com/apache/doris/pull/30514#discussion_r1469782765
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -524,8 +525,20 @@ std::tuple<bool, orc::Literal>
convert_to_orc_literal(const orc::Type* type, con
template <PrimitiveType primitive_type>
std::vector<OrcPredicate> value_range_to_predicate(
- const ColumnValueRange<primitive_type>& col_val_range, const
orc::Type* type) {
+ const ColumnValueRange<primitive_type>& col_val_range, const
orc::Type* type,
+ std::vector<orc::TypeKind>* cannot_predict_types) {
Review Comment:
```suggestion
std::vector<orc::TypeKind>* unsupported_pushdown_type) {
```
##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -785,9 +785,17 @@ Status VFileScanner::_get_next_reader() {
break;
}
case TFileFormatType::FORMAT_PARQUET: {
+ static const cctz::time_zone utc0 = cctz::utc_time_zone();
+ cctz::time_zone* tz;
+ if (range.__isset.table_format_params &&
+ range.table_format_params.table_format_type == "paimon") {
+ tz = const_cast<cctz::time_zone*>(&utc0);
Review Comment:
Why paimon use utc?
add comment in code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
