github-actions[bot] commented on code in PR #30452: URL: https://github.com/apache/doris/pull/30452#discussion_r1469160804
########## be/src/vec/runtime/vdatetime_value.cpp: ########## @@ -2170,17 +2177,32 @@ template <typename T> bool DateV2Value<T>::from_date_format_str(const char* format, int format_len, const char* value, Review Comment: warning: function 'from_date_format_str' has cognitive complexity of 248 (threshold 50) [readability-function-cognitive-complexity] ```cpp bool DateV2Value<T>::from_date_format_str(const char* format, int format_len, const char* value, ^ ``` <details> <summary>Additional context</summary> **be/src/vec/runtime/vdatetime_value.cpp:2179:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (value_len <= 0) [[unlikely]] { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2216:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp while (ptr < end && val < val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2216:** +1 ```cpp while (ptr < end && val < val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2218:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp while (val < val_end && isspace(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2218:** +1 ```cpp while (val < val_end && isspace(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2221:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (val >= val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2225:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2225:** +1 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2229:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp switch (*ptr++) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2234:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2237:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp int_value += int_value >= 70 ? 1900 : 2000; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2245:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2248:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (tmp - val <= 2) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2249:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp int_value += int_value >= 70 ? 1900 : 2000; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2259:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2268:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2276:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2286:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2295:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2312:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2322:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2333:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2344:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp while (tmp < val_end && isdigit(*tmp)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2344:** +1 ```cpp while (tmp < val_end && isdigit(*tmp)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2348:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (tmp - val > 6) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2350:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp if (!str_to_int64(val, &tmp2, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2353:** +1, nesting level increased to 4 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2354:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2358:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if constexpr (is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2366:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' || !hour_system_12) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2366:** +1 ```cpp if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' || !hour_system_12) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2369:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (toupper(*val) == 'P') { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2378:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2387:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2396:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2399:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value >= 7) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2402:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value == 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2411:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2422:** +1 ```cpp sunday_first = (*(ptr - 1) == 'U' || *(ptr - 1) == 'V'); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2424:** +1 ```cpp strict_week_number = (*(ptr - 1) == 'V' || *(ptr - 1) == 'v'); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2426:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2430:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (week_num > 53 || (strict_week_number && week_num == 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2430:** +1 ```cpp if (week_num > 53 || (strict_week_number && week_num == 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2430:** +1 ```cpp if (week_num > 53 || (strict_week_number && week_num == 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2441:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2449:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if constexpr (is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2451:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp if (!tmp_val.from_date_format_str("%I:%i:%S %p", 11, val, val_end - val, ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2462:** +1, nesting level increased to 4 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2467:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if constexpr (is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2469:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp if (!tmp_val.from_date_format_str("%H:%i:%S", 8, val, val_end - val, &tmp)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2479:** +1, nesting level increased to 4 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2484:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp while (val < val_end && ispunct(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2484:** +1 ```cpp while (val < val_end && ispunct(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2489:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp while (val < val_end && isalpha(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2489:** +1 ```cpp while (val < val_end && isalpha(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2494:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp while (val < val_end && isdigit(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2494:** +1 ```cpp while (val < val_end && isdigit(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2499:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if ('%' != *val) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2507:** +1, nesting level increased to 2 ```cpp } else if (!isspace(*ptr)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2508:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if (*ptr != *val) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2513:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2519:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp while (ptr < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2520:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2520:** +1 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2522:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp switch (*ptr++) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2540:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2545:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (!part_used) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2549:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (hour_system_12) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2550:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (hour > 12 || hour < 1) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2550:** +1 ```cpp if (hour > 12 || hour < 1) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2555:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (sub_val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2560:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (part_used & frac_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2561:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if constexpr (!is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2564:** +1, nesting level increased to 1 ```cpp } else if (part_used & time_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2565:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if constexpr (!is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2571:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (yearday > 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2573:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (!get_date_from_daynr(days)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2578:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (week_num >= 0 && weekday > 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2578:** +1 ```cpp if (week_num >= 0 && weekday > 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2580:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if ((strict_week_number && ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2581:** +1 ```cpp (strict_week_number_year < 0 || strict_week_number_year_type != sunday_first)) || ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2580:** +1 ```cpp if ((strict_week_number && ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2581:** +1 ```cpp (strict_week_number_year < 0 || strict_week_number_year_type != sunday_first)) || ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2582:** +1 ```cpp (!strict_week_number && strict_week_number_year >= 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2586:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp doris::calc_daynr(strict_week_number ? strict_week_number_year : year, 1, 1); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2590:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (sunday_first) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2591:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp days += ((weekday_b == 0) ? 0 : 7) - weekday_b + (week_num - 1) * 7 + weekday % 7; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2592:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2593:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp days += ((weekday_b <= 3) ? 0 : 7) - weekday_b + (week_num - 1) * 7 + weekday - 1; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2595:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (!get_date_from_daynr(days)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2603:** +1 ```cpp bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday > 0); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2603:** +1 ```cpp bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday > 0); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2604:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (already_set_date_part && already_set_time_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2604:** +1 ```cpp if (already_set_date_part && already_set_time_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2607:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (already_set_date_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2608:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if constexpr (is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2611:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2617:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (!(part_used & ~date_part)) { // only date here ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2618:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (!(part_used & day_part)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2620:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if (!(part_used & month_part)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2626:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (already_set_time_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2627:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if constexpr (is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2631:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2635:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if constexpr (is_datetime) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:2638:** +1, nesting level increased to 1 ```cpp } else { ^ ``` </details> ########## be/src/vec/runtime/vdatetime_value.cpp: ########## @@ -1199,26 +1191,40 @@ static int check_word(const char* lib[], const char* str, const char* end, const // change this method should also change that. bool VecDateTimeValue::from_date_format_str(const char* format, int format_len, const char* value, Review Comment: warning: function 'from_date_format_str' has cognitive complexity of 207 (threshold 50) [readability-function-cognitive-complexity] ```cpp bool VecDateTimeValue::from_date_format_str(const char* format, int format_len, const char* value, ^ ``` <details> <summary>Additional context</summary> **be/src/vec/runtime/vdatetime_value.cpp:1193:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (value_len <= 0) [[unlikely]] { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1229:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp while (ptr < end && val < val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1229:** +1 ```cpp while (ptr < end && val < val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1231:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp while (val < val_end && isspace(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1231:** +1 ```cpp while (val < val_end && isspace(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1234:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (val >= val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1238:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1238:** +1 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1242:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp switch (*ptr++) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1247:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1250:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp int_value += int_value >= 70 ? 1900 : 2000; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1258:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1261:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (tmp - val <= 2) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1262:** +5, including nesting penalty of 4, nesting level increased to 5 ```cpp int_value += int_value >= 70 ? 1900 : 2000; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1272:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1281:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1289:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1299:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1308:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1325:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1335:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1346:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1357:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1364:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' || !hour_system_12) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1364:** +1 ```cpp if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' || !hour_system_12) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1367:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (toupper(*val) == 'P') { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1376:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1385:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value < 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1394:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1397:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value >= 7) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1400:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (int_value == 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1409:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1420:** +1 ```cpp sunday_first = (*(ptr - 1) == 'U' || *(ptr - 1) == 'V'); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1422:** +1 ```cpp strict_week_number = (*(ptr - 1) == 'V' || *(ptr - 1) == 'v'); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1424:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1428:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (week_num > 53 || (strict_week_number && week_num == 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1428:** +1 ```cpp if (week_num > 53 || (strict_week_number && week_num == 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1428:** +1 ```cpp if (week_num > 53 || (strict_week_number && week_num == 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1439:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!str_to_int64(val, &tmp, &int_value)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1448:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!tmp_val.from_date_format_str("%I:%i:%S %p", 11, val, val_end - val, &tmp)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1461:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if (!tmp_val.from_date_format_str("%H:%i:%S", 8, val, val_end - val, &tmp)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1473:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp while (val < val_end && ispunct(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1473:** +1 ```cpp while (val < val_end && ispunct(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1478:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp while (val < val_end && isalpha(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1478:** +1 ```cpp while (val < val_end && isalpha(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1483:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp while (val < val_end && isdigit(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1483:** +1 ```cpp while (val < val_end && isdigit(*val)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1488:** +4, including nesting penalty of 3, nesting level increased to 4 ```cpp if ('%' != *val) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1496:** +1, nesting level increased to 2 ```cpp } else if (!isspace(*ptr)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1497:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if (*ptr != *val) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1502:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1508:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp while (ptr < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1509:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1509:** +1 ```cpp if (*ptr == '%' && ptr + 1 < end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1511:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp switch (*ptr++) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1529:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1534:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (!part_used) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1538:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (hour_system_12) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1539:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (hour > 12 || hour < 1) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1539:** +1 ```cpp if (hour > 12 || hour < 1) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1544:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (sub_val_end) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1549:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (part_used & date_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1550:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (part_used & time_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1552:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1555:** +1, nesting level increased to 1 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1562:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (yearday > 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1564:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (!get_date_from_daynr(days)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1569:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (week_num >= 0 && weekday > 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1569:** +1 ```cpp if (week_num >= 0 && weekday > 0) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1571:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if ((strict_week_number && ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1572:** +1 ```cpp (strict_week_number_year < 0 || strict_week_number_year_type != sunday_first)) || ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1571:** +1 ```cpp if ((strict_week_number && ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1572:** +1 ```cpp (strict_week_number_year < 0 || strict_week_number_year_type != sunday_first)) || ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1573:** +1 ```cpp (!strict_week_number && strict_week_number_year >= 0)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1577:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp doris::calc_daynr(strict_week_number ? strict_week_number_year : year, 1, 1); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1581:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (sunday_first) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1582:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp days += ((weekday_b == 0) ? 0 : 7) - weekday_b + (week_num - 1) * 7 + weekday % 7; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1583:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1584:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp days += ((weekday_b <= 3) ? 0 : 7) - weekday_b + (week_num - 1) * 7 + weekday - 1; ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1586:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (!get_date_from_daynr(days)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1594:** +1 ```cpp bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday > 0); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1594:** +1 ```cpp bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday > 0); ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1595:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (already_set_date_part && already_set_time_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1595:** +1 ```cpp if (already_set_date_part && already_set_time_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1599:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (!(part_used & ~date_part)) { // only date here ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1600:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (!(part_used & day_part)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1602:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp if (!(part_used & month_part)) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1608:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (already_set_date_part) { ^ ``` **be/src/vec/runtime/vdatetime_value.cpp:1611:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (already_set_time_part) { ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org