morningman commented on code in PR #30437: URL: https://github.com/apache/doris/pull/30437#discussion_r1468719323
########## fe/fe-core/src/main/java/org/apache/doris/transaction/TableCommitInfo.java: ########## @@ -68,6 +78,10 @@ public void readFields(DataInput in) throws IOException { idToPartitionCommitInfo.put(partitionCommitInfo.getPartitionId(), partitionCommitInfo); } } + if (Env.getCurrentEnvJournalVersion() >= FeMetaVersion.VERSION_129) { Review Comment: Change it to Gson this time ########## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ########## @@ -175,6 +177,11 @@ public enum OlapTableState { private AutoIncrementGenerator autoIncrementGenerator; + @SerializedName(value = "visibleVersion") Review Comment: Move these to Table.java 's `TableAttributes`, so no need to update meta version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org