github-actions[bot] commented on code in PR #30466:
URL: https://github.com/apache/doris/pull/30466#discussion_r1468456346


##########
be/src/util/bit_stream_utils.inline.h:
##########
@@ -86,10 +86,12 @@ void BitWriter::PutAligned(T val, int num_bytes) {
     memcpy(ptr, &val, num_bytes);
 }
 
-inline void BitWriter::PutVlqInt(int32_t v) {
+inline void BitWriter::PutVlqInt(uint32_t v) {

Review Comment:
   warning: method 'PutVlqInt' can be made static 
[readability-convert-member-functions-to-static]
   
   be/src/util/bit_stream_utils.h:69:
   ```diff
   -     void PutVlqInt(uint32_t v);
   +     static void PutVlqInt(uint32_t v);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to