morningman commented on code in PR #29989: URL: https://github.com/apache/doris/pull/29989#discussion_r1468268577
########## fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVRelatedTableIf.java: ########## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.mtmv; + +import org.apache.doris.catalog.Column; +import org.apache.doris.catalog.PartitionItem; +import org.apache.doris.catalog.PartitionType; +import org.apache.doris.catalog.TableIf; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.common.DdlException; + +import java.util.List; +import java.util.Map; +import java.util.Set; + +/** + * The table that implements this interface can serve as a partition table followed by MTMV + */ +public interface MTMVRelatedTableIf extends TableIf { + Review Comment: Add comment for all these interface ########## fe/fe-core/src/main/java/org/apache/doris/planner/external/hudi/HudiScanNode.java: ########## @@ -194,7 +194,7 @@ private List<HivePartition> getPrunedPartitions( return filteredPartitionIds.stream().map(id -> { String path = basePath + "/" + partitionIdToNameMap.get(id); return new HivePartition( - dbName, tblName, false, inputFormat, path, partitionValuesMap.get(id)); + dbName, tblName, false, inputFormat, path, partitionValuesMap.get(id), null); Review Comment: Better pass an empty map, not `null` ########## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ########## @@ -2535,4 +2537,37 @@ public List<Tablet> getAllTablets() throws AnalysisException { } return tablets; } + + @Override + public PartitionType getPartitionType() { + return partitionInfo.getType(); + } + + @Override + public Map<Long, PartitionItem> getPartitionItems() { + return getPartitionInfo().getIdToItem(false); + } + + @Override + public long getPartitionLastModifyTime(long partitionId, PartitionItem item) throws AnalysisException { + return getPartitionOrAnalysisException(partitionId).getVisibleVersionTimeIgnoreInit(); + } + + @Override + public long getLastModifyTime() { Review Comment: what will the last modify time be if a partition is dropped? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
