github-actions[bot] commented on code in PR #30414: URL: https://github.com/apache/doris/pull/30414#discussion_r1467273494
########## be/src/vec/functions/match.cpp: ########## @@ -311,6 +311,65 @@ Status FunctionMatchPhrase::execute_match(const std::string& column_name, return Status::OK(); } +Status FunctionMatchPhrasePrefix::execute_match( Review Comment: warning: method 'execute_match' can be made static [readability-convert-member-functions-to-static] ```suggestion static Status FunctionMatchPhrasePrefix::execute_match( ``` be/src/vec/functions/match.cpp:316: ```diff - const ColumnArray::Offsets64* array_offsets, ColumnUInt8::Container& result) const { + const ColumnArray::Offsets64* array_offsets, ColumnUInt8::Container& result) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org