github-actions[bot] commented on code in PR #28082: URL: https://github.com/apache/doris/pull/28082#discussion_r1467199113
########## be/src/olap/tablet_meta.cpp: ########## @@ -720,6 +720,16 @@ Version TabletMeta::max_version() const { return max_version; } +size_t TabletMeta::version_count_cross_with_range(const Version& range) const { Review Comment: warning: method 'version_count_cross_with_range' can be made static [readability-convert-member-functions-to-static] ```suggestion size_t TabletMeta::version_count_cross_with_range(const Version& range) { ``` be/src/olap/tablet_meta.h:164: ```diff - size_t version_count_cross_with_range(const Version& range) const; + static size_t version_count_cross_with_range(const Version& range) ; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org