morningman commented on a change in pull request #6466: URL: https://github.com/apache/incubator-doris/pull/6466#discussion_r690963999
########## File path: be/src/exprs/tuple_is_null_predicate.cpp ########## @@ -36,8 +36,10 @@ Status TupleIsNullPredicate::prepare(RuntimeState* state, const RowDescriptor& r // Resolve tuple ids to tuple indexes. for (int i = 0; i < _tuple_ids.size(); ++i) { int32_t tuple_idx = row_desc.get_tuple_idx(_tuple_ids[i]); - if (row_desc.tuple_is_nullable(tuple_idx)) { - _tuple_idxs.push_back(tuple_idx); + if (tuple_idx != RowDescriptor::INVALID_IDX) { Review comment: Why there is INVALID_IDX? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org