github-actions[bot] commented on code in PR #30277:
URL: https://github.com/apache/doris/pull/30277#discussion_r1466734325
##########
be/src/vec/exec/vpartition_sort_node.cpp:
##########
@@ -89,23 +90,23 @@ Status VPartitionSortNode::prepare(RuntimeState* state) {
return Status::OK();
}
-Status VPartitionSortNode::_split_block_by_partition(vectorized::Block*
input_block,
- int batch_size) {
+Status VPartitionSortNode::_split_block_by_partition(RuntimeState*
runtime_state,
Review Comment:
warning: method '_split_block_by_partition' can be made const
[readability-make-member-function-const]
be/src/vec/exec/vpartition_sort_node.cpp:93:
```diff
- vectorized::Block*
input_block) {
+ vectorized::Block*
input_block) const {
```
be/src/vec/exec/vpartition_sort_node.h:268:
```diff
- Status _split_block_by_partition(RuntimeState* runtime_state,
vectorized::Block* input_block);
+ Status _split_block_by_partition(RuntimeState* runtime_state,
vectorized::Block* input_block) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
